[i2c] [PATCH] i2c: __must_check fixes (chip drivers)

Aurelien Jarno aurelien at aurel32.net
Wed Aug 23 19:57:26 CEST 2006


Jean Delvare a écrit :
> i2c: __must_check fixes (chip drivers)
> 
> Check for error on sysfs file creation.
> Delete sysfs files on device removal.
> 
> The approach taken for the most complex case (pcf8591) is similar to
> what Mark M. Hoffman proposed for hardware monitoring chip drivers.
> 
> I could only test eeprom myself, so I would appreciate if users of the
> other affected drivers could test and report. The theory is that
> nothing should change seen from user-space.
> 

Sorry for being so long to test, I was a bit busy.

The pcf8574 driver works correctly, ie as before. I think you can merge 
the patch.

The pcf8591 driver does not work, ie it does not detect the chip. I 
don't know if it is a problem on my side or of the driver, I will try to 
investigate the problem this evening.

-- 
   .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
  : :' :  Debian developer           | Electrical Engineer
  `. `'   aurel32 at debian.org         | aurelien at aurel32.net
    `-    people.debian.org/~aurel32 | www.aurel32.net



More information about the i2c mailing list