[i2c] [PATCH] i2c: __must_check fixes (chip drivers)

Jean Delvare khali at linux-fr.org
Thu Aug 24 17:13:45 CEST 2006


Hi Aurelien,

> > Sorry for being so long to test, I was a bit busy.

No worry, better late than never :)

> > The pcf8574 driver works correctly, ie as before. I think you can merge 
> > the patch.
> > 
> > The pcf8591 driver does not work, ie it does not detect the chip. I 
> > don't know if it is a problem on my side or of the driver, I will try to 
> > investigate the problem this evening.
> 
> The pcf8591 also works correctly. It was a problem in one of my cables, 
> and also becaused I used lm-sensors to read values from the chip, and it 
> does not display anything about this chip anymore.
> 
> I'll have a look at lm-sensors later, meanwhile as I am ok with both of 
> the kernel patches, so you can merge them.

OK, thanks a lot for testing.

It is expected that the pcf8591 data will no more be shown by sensors.
As of 2.10.0, libsensors only considers hardware monitoring chips (the
ones which are registered with the kernel's hwmon class.) So for
example eeproms are no more displayed either. This is a required step
for the planned evolution of the library, taking benefit of the standard
sysfs interface to sensor chips.

-- 
Jean Delvare



More information about the i2c mailing list