[i2c] Add ARM Versatile and Realview I2C driver

Jean Delvare khali at linux-fr.org
Sat Dec 2 13:22:30 CET 2006


Hi Russell,

On Thu, 30 Nov 2006 20:58:35 +0000, Russell King wrote:
> On Thu, Nov 30, 2006 at 08:44:22PM +0100, Jean Delvare wrote:
> > Note that in theory i2c_del_adapter could fail.
> 
> Eww.  That would not be nice for hot-pluggable hardware.  Luckily this
> isn't, but note that even if we did return the error to the driver
> model via the remove method, the driver model itself ignores the
> return code and would continue to unbind the driver.

I wonder why the remove method has to return an int, rather than void,
then.

> > OK, looks alright to me now. Care to resubmit a complete patch that I
> > could apply to my tree?
> 
> Follows:
> 
> Add ARM Versatile and Realview I2C driver
> 
> Add support for the I2C bus found on the ARM Versatile and Realview
> platforms.  The I2C bus has a RTC and optionally some EEPROMs attached.
> 
> Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>

Applied, thanks.

-- 
Jean Delvare



More information about the i2c mailing list