[i2c] [PATCH] AT91 I2C driver update

Jean Delvare khali at linux-fr.org
Fri Dec 8 18:09:04 CET 2006


On 08 Dec 2006 18:37:47 +0200, Andrew Victor wrote:
> > What would happen without the changes below, compilation
> > failure?
> 
> Yes.
> 
> at91rm9200_twi.h has been renamed to at91_twi.h
> arch_identify() no longer exists.
> 
> 
> > > @@ -244,9 +244,9 @@
> > >  	return 0;
> > >  
> > >  fail3:
> > > -	clk_disable(twi_clk);
> > >  	platform_set_drvdata(pdev, NULL);
> > >  	kfree(adapter);
> > > +	clk_disable(twi_clk);
> > >  fail2:
> > >  	clk_put(twi_clk);
> > >  fail1:
> > 
> > What is this change for? Does it actually fix a bug, or...?
> 
> It's was just making the failure-path a bit more logical.
> Nothing serious.

OK. I've merged these fixes into the original patch. I didn't want to
make it a separate patch because it's no good to ship patches which
break compilation.

Thanks,
-- 
Jean Delvare



More information about the i2c mailing list