[i2c] [patch 2.6.19-rc6 12/11] hwmon updates

[David Brownell]

Thanks for the feedback; it's addressed in the latest patches,
except a few like:

> > --- g26.orig/drivers/hwmon/w83781d.c	2006-11-06 11:50:26.000000000 -0800
> > +++ g26/drivers/hwmon/w83781d.c	2006-12-03 13:21:45.000000000 -0800
> > @@ -1021,17 +1021,17 @@ w83781d_detect(struct i2c_adapter *adapt
> >  	/* Prevent users from forcing a kind for a bus it isn't supposed
> >  	   to possibly be on */
> >  	if (is_isa && (kind == as99127f || kind == w83783s)) {
> > -		dev_err(&adapter->dev,
> > +		dev_err(adapter->class_dev.dev,
> 
> Might be worth introducing a local dev variable for this driver, that
> would save a lot of line wrapping.

Where the lines were already wrapping badly, the driver already had
problems exceeding 80 character line length, or it was mixing spaces
into the indentation ("only use tabs"), I decided to avoid creating
more work and a larger patch.




> > @@ -727,7 +729,6 @@ int vt8231_detect(struct i2c_adapter *ad
> >  	client->addr = isa_address;
> >  	client->adapter = adapter;
> >  	client->driver = &vt8231_driver;
> > -	client->dev.parent = &adapter->dev;
> 
> This change is independent and could be applied separate from the
> patchset, right? If so, please provide a separate patch and I'll apply
> it right away.

Yes.   See the appended.

- Dave

=========	CUT HERE
Remove a superfluous initialization from the vt8231 hwmon driver; the
i2c core does this, and the source field will be vanishing soon.

Signed-off-by: David Brownell <dbrownell at users.sourceforge.net>

Index: at91/drivers/hwmon/vt8231.c
===================================================================
--- at91.orig/drivers/hwmon/vt8231.c	2006-12-15 10:41:47.000000000 -0800
+++ at91/drivers/hwmon/vt8231.c	2006-12-15 10:45:15.000000000 -0800
@@ -727,7 +729,6 @@ int vt8231_detect(struct i2c_adapter *ad
 	client->addr = isa_address;
 	client->adapter = adapter;
 	client->driver = &vt8231_driver;
-	client->dev.parent = &adapter->dev;
 
 	/* Fill in the remaining client fields and put into the global list */
 	strlcpy(client->name, "vt8231", I2C_NAME_SIZE);