[i2c] [patch 2.6.20-rc1 2/6] I2C adapters (mostly) stop using i2c_adapter.dev

[David Brownell]

On Monday 18 December 2006 9:36 am, Jean Delvare wrote:

> > @@ -198,19 +202,17 @@ static void __exit i2c_isa_exit(void)
> >  #endif
> >  
> >  	/* Clean up the sysfs representation */
> > -	dev_dbg(&isa_adapter.dev, "Unregistering from sysfs\n");
> > -	init_completion(&isa_adapter.dev_released);
> > -	init_completion(&isa_adapter.class_dev_released);
> 
> Huh, why are you removing these init_completion calls? I doubt the
> i2c-isa driver will work properly without them at this point.
> 
> > +	dev_dbg(isa_adapter.class_dev.dev, "Unregistering from sysfs\n");
> >  	class_device_unregister(&isa_adapter.class_dev);
> > -	device_remove_file(&isa_adapter.dev, &dev_attr_name);
> > -	device_unregister(&isa_adapter.dev);
> > +	platform_device_unregister(to_platform_device(isa_adapter.class_dev.dev));
> 
> What's that?

That whole patch fragment was accidentally moved in its entirety from the
original "update just i2c-isa" patch.  The completion init was _moved_ to
where it should have been always (probe method), and the code created its
platform device differently.

I'll send an updated patch soonish.

- Dave