[i2c] i2c header changes in 2.6.17-git2

David Woodhouse dwmw2 at infradead.org
Thu Jun 22 16:06:59 CEST 2006


On Thu, 2006-06-22 at 08:30 +0200, Jean Delvare wrote:
> Do not export the following i2c header files to user space:
> 
> * i2c-id.h: These IDs are internal to the kernel and user space
>   does not need them.
> * i2c-algo-ite.h: The driver is broken and planned for removal, so
>   let's not export it for now. The extra ioctl defined here can
>   be standardized and moved to i2c-core/i2c-dev if really needed.
> 
> Signed-off-by: Jean Delvare <khali at linux-fr.org>

Thanks. I've applied that to the hdrinstall2 git tree at
git://git.infradead.org/hdrinstall2-2.6.git (and
http://git.infradead.org/?p=hdrinstall2-2.6.git ), so it should be in
Andrew's next -mm release.

> As a side note, given the line-oriented way diff and patch work, I fear
> that having that many file names on each line will cause trouble in the
> future (understand: colliding patches.) Don't you think that having one
> file name per line would be better?

Yeah, I did consider that option. When the dust settles on this lot, we
really shouldn't be updating it that often though. I'm not sure it's
worth it.

Having to hit M-x makefile-mode and ESC-q occasionally isn't that much
of a hardship in the meantime :)

-- 
dwmw2




More information about the i2c mailing list