[i2c] [PATCH for 2.6.18-mm3] cleanup of i2c-nforce2, 3rd iteration

Hans-Frieder Vogt hfvogt at gmx.net
Mon Oct 16 22:30:08 CEST 2006


Hi Jean,

Am Montag, 16. Oktober 2006 12:57 schrieb Jean Delvare:
> Hi Hans-Frieder,
> 
> On Sun, 15 Oct 2006 23:35:01 +0200, Hans-Frieder Vogt wrote:
> > here is another patch for i2c-nforce2, which is now basically
> > the same as already sent by Jean on 7th October.
> > Compared to the 2nd iteration, I removed again the block data
> > transfer, because the way I implemented it was
> > not safe enough. I will rethink it, and, provided that I find
> > a better way, provide another patch. At least I took
> > the opportunity to remove more of the unused definitions in
> > the driver, so that it should now only contain
> > what is really needed.
> > 
> > Hans-Frieder
> > 
> > 
> > Summary of changes:
> > 
> > - fixes:
> >    o legacy I/O region size is 64 bytes, not 8 bytes
> > - general cleanup:
> >    o removed code for the unsupported I2C block data, block data,
> >       proc call and block proc call transfer modes
> >    o removed detail warnings about unsupported modes that are
> >      covered in a general warning (unsupported transaction...)
> >      anyway
> >    o removed necessity of a definition of struct i2c_adapter
> >    o moved definition of struct i2c_algorithm, making forward
> >      declarations of nforce2_access and nforce2_func unnecessary
> > - minor changes:
> >    o in the description mention the nForce 5xx chipsets
> 
> Err, do we actually support these right now? What PCI IDs do you
> consider to be nForce 5xx chips?

As far as I know, the MCP55 series of chips is marketed as the nForce 5xx series. Therefore I consider
the PCI-ID 0x0368 to be the nForce 5xx SMBus device.

> 
> >    o changes my e-mail address in MODULE_AUTHOR
> 
> All the rest is fine by me.
> 
> Thanks,
Thanks as well,

-- 
--
Hans-Frieder Vogt                 e-mail: hfvogt <at> arcor .dot. de
                                          hfvogt <at> gmx .dot. net



More information about the i2c mailing list