[i2c] [patch 2.6.21-rc5-git +i2c 2/2] convert tps65010 to new-style driver

Jean Delvare khali at linux-fr.org
Sun Apr 8 17:33:29 CEST 2007


On Thu, 5 Apr 2007 13:07:19 -0700, David Brownell wrote:
> On Thursday 05 April 2007 12:05 pm, Jean Delvare wrote:
> > > +static struct i2c_board_info __initdata h2_i2c_board_info[] = {
> > > +{
> > > +	I2C_BOARD_INFO("tps65010", 0x48),
> > > +	.type		= "tps65010",
> > > +	.irq		= OMAP_GPIO_IRQ(58),
> > > +},
> > 
> > You're missing one level of indentation here, and same for the other
> > declarations later on.
> 
> I don't see anything in Documentation/CodingStyle saying that ...

Well, when you end up closing two curly braces at the same level of
indentation, it can't be correct.

> > > +	/* gpio3 for SD, gpio4 for VDD_DSP */
> > > +	// FIXME power DSP iff it's configured
> > 
> > No C++-style comments please.
> 
> If you insist ... but then it's likely to *NEVER* get fixed!  :(

I don't understand what you mean here, sorry.

-- 
Jean Delvare



More information about the i2c mailing list