[i2c] [PATCH] DaVinci I2C controller support (take#4)

Jean Delvare khali at linux-fr.org
Wed Aug 29 18:41:50 CEST 2007


Hi Vladimir,

On Wed, 29 Aug 2007 19:05:09 +0400, Vladimir Barinov wrote:
> The patch inlined below adds I2C DaVinci controller support after your last review.
> 
> > Weird. Can't the firmware be fixed instead?
> > Does the locking happens even when not addressing the MSP430? Do you
> > have a driver for it? 
> I haven't.
> 
> I've corrected the places you have pointed to and also I've removed the code related to MSP430 firmware fixes.
> We haven't got the TI's response and decided to omit that code. The locking is not reproduceable for other 
> devices on i2c bus. I assume that the firmware should certainly be fixed.

Great. This makes the i2c-davinci driver look much nicer :)

> The patch is against 2.6.23-rc4 kernel version.

Looks good to me now, I've applied it. This will go into the next -mm,
and will be merged into Linus' tree for 2.6.24-rc1.

-- 
Jean Delvare



More information about the i2c mailing list