[i2c] [PATCH] basic gpio_chip support for 16-bit PCA9539 GPIO expander

[Jean Delvare]

Hi David,

On Wed, 5 Dec 2007 20:15:28 -0800, David Brownell wrote:
> On Monday 03 December 2007, eric miao wrote:
> > --- a/drivers/i2c/chips/Kconfig
> > +++ b/drivers/i2c/chips/Kconfig
> 
> Jean suggets moving this to drivers/gpio ... I'd suggest doing that as
> a separate patch, assuming we go with a drivers/gpio directory.

I see little point in a separate patch. Eric's driver has so little in
common with the original pca9539 driver that the patch is hardly
readable. It would make more sense to have one patch adding the new
driver to drivers/gpio and another patch removing the original driver
from drivers/i2c/chips (now or later, as discussed elsewhere in this
thread.)

> > @@ -67,7 +67,7 @@ config SENSORS_PCF8574
> >
> >  config SENSORS_PCA9539
> >  	tristate "Philips PCA9539 16-bit I/O port"
> > -	depends on EXPERIMENTAL
> > +	depends on EXPERIMENTAL && GPIO_LIB
> 
> What's EXPERIMENTAL about it though?

Traditionally, i2c drivers are added with EXPERIMENTAL and we remove it
after a few months. But it seems that we forgot to remove it for this
driver.

-- 
Jean Delvare