[i2c] [patch] i2c: announce SMBus host controllers

[Jean Delvare]

Hi Bjorn,

Le 21/12/2007, Bjorn Helgaas a écrit:
>Would you consider adding a patch like this to your i2c tree?
>Unfortunately, I don't think I have hardware for any of these
>devices, so all I have done is compiled this.
>(...)
>i2c: announce SMBus host controllers
>
>Note where we find SMBus host controllers and what resources they use.

I like the idea. The information printed is somewhat redundant with
/proc/ioports but sometimes it's useful to see the information in dmesg
directly, and having a common string to grep for should be convenient as
well. Just a couple comments:

* i2c-i810, i2c-prosavage, i2c-savage4 and i2c-voodoo3 are NOT SMBus host
controller drivers. They do I2C/DDC over GPIO for graphics adapters. I
don't think that you really need to know about the resources they use,
they are not candidates for conflicts with ACPI / BIOS / whatever. And 3
out of 4 are deprecated, so all in all they are probably just not worth
modifying.

* I think that you should make sure that the device has been successfully
registered before you print the message, otherwise it might be
confusing. I only looked at i2c-pasemi and scx200_acb and for both
drivers you print the message at a point where a failure could still
happen. Please double-check for all drivers, adjust as needed and
resubmit.

I can test the i2c-i801 driver now and i2c-viapro and i2c-piix4 later.

--
Jean Delvare