[i2c] [PATCH] change to i2c-i801 driver to use internal 32-byte buffer on ICH4+
Mark M. Hoffman
mhoffman at lightlink.com
Fri Jun 8 14:17:39 CEST 2007
Hi Oleg, Jean:
> On Thu, 7 Jun 2007 11:46:09 -0700, Oleg Ryjkov wrote:
> > This patch adds an ability to utilize the internal SRAM buffer on ICH4
> > and newer host controllers to speed up execution of block operations.
(...)
> > static int isich4;
I never liked this variable name; humbly suggest 'has_block_buffer' or maybe
just 'eb32' if you're a minimalist. The flag should indicate the feature
itself, not the (arbitrary) name of the first in the series to support it.
Regards,
--
Mark M. Hoffman
mhoffman at lightlink.com
More information about the i2c
mailing list