[i2c] i2c-davinci bus controller driver status
Trilok Soni
soni.trilok at gmail.com
Mon Jun 18 08:05:15 CEST 2007
Hi Vladimir,
On 6/15/07, Jean Delvare <khali at linux-fr.org> wrote:
> Hi Vladimir,
>
> On Thu, 14 Jun 2007 16:22:05 +0400, Vladimir A. Barinov wrote:
> > Could you say is there any status on the patch for DaVinci i2c
> > bus controller driver?
> > http://lists.lm-sensors.org/pipermail/i2c/2007-April/001040.html
> >
> > I just want to check if it did get your attention since there were
> > no any response in the thread.
>
> I didn't have the time to review it when Vitaly posted it, and then
> forgot about it. I was hoping that someone else could do a first review
> so that I would only have to push it upstream. This is a pretty big
> driver (for an I2C controller) and I'm short of time.
>
> So, to answer your question, the status is: stuck. Is there any
> volunteer to review the i2c-davinci driver?
I can do this.
i2c-davinci is very much similar to i2c-omap.c which was submitted by
Komal Shah <komal_shah802003 at yahoo.com> to mainline and most the
review comments (actually 4-5 rounds of comments from Jean :)) given
for it and same comments applies for i2c-davinci.c. So please go
through following links and make similar changes.
http://lkml.org/lkml/2006/8/2/138
http://lkml.org/lkml/2006/8/5/23
http://lkml.org/lkml/2006/8/2/140
http://lists.lm-sensors.org/pipermail/i2c/2006-August/000142.html
http://linux.omap.com/pipermail/davinci-linux-open-source/2006-September/000971.html
Also please change to adapt to new I2C style.
i2c_add_numbered_adapter(..). And if you really want zero length
transfers hack then please maintain in davinci-git tree only, but
please remove from mainline submission.
Thanx. We can start next review once you submit as per above comments.
--
--Trilok Soni
More information about the i2c
mailing list