[i2c] i2c-davinci bus controller driver status

Trilok Soni soni.trilok at gmail.com
Tue Jun 19 11:31:31 CEST 2007


On 6/19/07, Jean Delvare <khali at linux-fr.org> wrote:
> Hi Trilok,
>

...

>
> > i2c-davinci is very much similar to i2c-omap.c which was submitted by
> > Komal Shah <komal_shah802003 at yahoo.com> to mainline and most the
> > review comments (actually 4-5 rounds of comments from Jean :)) given
> > for it and same comments applies for i2c-davinci.c. So please go
> > through following links and make similar changes.
>
> Are these similar enough that having a single driver for both would
> make sense?

No. controller register set and offsets are quite different, so it is
better to have different driver . Only driver style is derived here.

>
> > http://lkml.org/lkml/2006/8/2/138
> > http://lkml.org/lkml/2006/8/5/23
> > http://lkml.org/lkml/2006/8/2/140
> > http://lists.lm-sensors.org/pipermail/i2c/2006-August/000142.html
> > http://linux.omap.com/pipermail/davinci-linux-open-source/2006-September/000971.html
> >
> > Also please change to adapt to new I2C style.
> > i2c_add_numbered_adapter(..). And if you really want zero length
> > transfers hack then please maintain in davinci-git tree only, but
> > please remove from mainline submission.
>
> If only new-style chip drivers are used, then it's possible that
> zero-length transactions won't be needed at all.
>

True. But until all the chip drivers are converted to use the new
style, davinci guys can maintain this zero-length patch in their git
tree like we do in OMAP.

-- 
--Trilok Soni



More information about the i2c mailing list