[i2c] [PATCH 2of3] change i2c-i801 driver to use internal 32-byte buffer on ICH4+

Jean Delvare khali at linux-fr.org
Wed Jun 20 16:52:28 CEST 2007


Hi Oleg,

On Tue, 19 Jun 2007 18:22:14 -0700, Oleg Ryjkov wrote:
> I've changed your patch in accordance with your comments. It should
> apply after my first patch to this file(and the changes you mentioned in
> the previous email to me).
> Thanks for your thorough review.
> (...)
> Signed-off-by: Oleg Ryjkov <olegr at google.com>
> 
> 
> --- linux-2.6-untouched/drivers/i2c/busses/i2c-i801.c	2007-06-19 18:21:18.000000000 -0700
> +++ linux-2.6/drivers/i2c/busses/i2c-i801.c	2007-06-19 18:19:15.000000000 -0700

Patch applied, thanks. I've tested it on an ICH5 and the performance
boost is pretty impressive. At HZ=250, the SMBus block read went down
from 120 ms to 24 ms - a 5 times speedup! Pretty impressive. Hopefully
this will benefit the I2C block read too, if I could find some time to
implement it :(

I also tested on an ICH3-M system (no block buffer), no regression here.

Good work, thanks.

-- 
Jean Delvare



More information about the i2c mailing list