[i2c] [PATCH] PXA I2C: Update PXA platforms to support new-style I2C drivers.

Jean Delvare khali at linux-fr.org
Thu Jun 21 20:46:26 CEST 2007


On Wed, 20 Jun 2007 17:35:59 -0700, David Brownell wrote:
> On Wednesday 20 June 2007, Jean Delvare wrote:
> > Hi David,
> > 
> > > > -	ret = i2c_add_adapter(&i2c->adap);
> > > > +	if (dev->id >= 0) {
> > > 
> > > I suggest you just always use the add_numbered() call.
> > > 
> > > Not only does nothing actually use negative IDs in the
> > > current kernel ... but if they did, the right way to
> > > handle it would be as bus number zero.  The reason to
> > > do so is to avoid sysfs names that only make sense when
> > > there are multiple adapters.
> > 
> > Good point. Rodolfo, can I have an updated patch?
> > 
> > David, would this also apply to the i2c-gpio driver?
> > http://lists.lm-sensors.org/pipermail/i2c/2007-June/001458.html
> 
> I don't see why it wouldnt'.

OK. Atsushi, can you please update your i2c-gpio patch to do the same
as this i2c-pxa patch?

http://lists.lm-sensors.org/pipermail/i2c/2007-June/001499.html

Thanks,
-- 
Jean Delvare



More information about the i2c mailing list