[i2c] [patch 1/5] i2c stack can probe()

David Brownell david-b at pacbell.net
Mon Mar 5 23:42:11 CET 2007


On Sunday 04 March 2007 2:57 am, Jean Delvare wrote:
> Hi David,
> 
> On Sat, 3 Mar 2007 09:54:32 -0800, David Brownell wrote:
> > The basic issue was that i2c_client.driver isn't needed, because
> > i2c_client.dev.driver suffices ... in the same way, we don't need
> > both i2c_client.adapter and i2c_client.dev.parent; or the driver
> > model refcount and i2c_client.usage_count for that matter.  When
> > that duplication vanishes, such questions will vanish.  :)
> 
> I never realized there was so much duplication in the i2c core
> structures. Now I'm eagerly waiting for your patches cleaning it all
> up ;)

I can do a first pass, but I'll want you to handle most of the mess;
the first two patches affect *every i2c_client driver* as well as the
core.  (Primarily one-line changes, except client->adapter.)  The mess
being making sure my first pass of such huge stuff is correct, and
merges without breaking too much.  ;)

There's also i2c_adapter.list and i2c_client.list, each of which
duplicates driver model state...

- Dave




More information about the i2c mailing list