[i2c] [patch 2.6.21-rc3-git +i2c 2/5] i2c stack can remove()

Jean Delvare khali at linux-fr.org
Sun Mar 11 13:37:16 CET 2007


On Sat, 10 Mar 2007 20:48:38 -0800, David Brownell wrote:
> On Friday 09 March 2007 12:53 pm, Jean Delvare wrote:
> > Additionally, I know we discussed this before and I was in favor of
> > this separate function for unregistering new-style drivers but... A
> > real world experiment convinced me easily that this wasn't a good idea.
> > Nobody checks the return value of i2c_del_driver() which is called by
> > all drivers for now, so people won't notice they are doing something
> > wrong when porting drivers to the new model.
> 
> In that case, it would make sense to change the signature.  None of
> the standard driver model calls report faults on those code paths
> either -- for the same reasons.

Fine with me. Given that this function was always returning 0 anyway...
Maybe this can be made a separate patch though, so that this change
isn't burried in the rest and people get a chance to spot it.

> > What do you think? 
> 
> Looks about right.  I'll probably roll that into a revised patch.

Great, waiting for it :)

-- 
Jean Delvare



More information about the i2c mailing list