[i2c] [patch 2.6.21-rc3-git +i2c 4/5] i2c board_info and i2c_new_device()

David Brownell david-b at pacbell.net
Fri Mar 16 20:51:44 CET 2007


On Friday 16 March 2007 12:17 am, Jean Delvare wrote:

> > +	if (client->driver) {
> > +		client->dev.driver = &client->driver->driver;
> > +
> > +	if (client->driver && !is_newstyle_driver(client->driver))
> > +		client->dev.release = i2c_client_release;
> > +	} else
> > +		client->dev.release = i2c_client_dev_release;
> >  
> >  	snprintf(&client->dev.bus_id[0], sizeof(client->dev.bus_id),
> >  		"%d-%04x", i2c_adapter_id(adapter), client->addr);
> 
> Hmm, the strange indentation makes me wonder if the new code really
> does what you meant it to do. I guess you want the same but _without_
> the curly braces?

Grr, yes.  I seem not to have written the relevant editor buffer.
Please tweak your version of the patch.

- Dave



More information about the i2c mailing list