[i2c] problem with DS1337 RTC connected to Cirrus Logic EP93XX

[Lennert Buytenhek]

On Fri, May 04, 2007 at 03:39:35PM +0200, Jean Delvare wrote:

> Hi Lennert,

Hi Jean,


> > The latest one I have is:
> > 
> > 	http://svn.wantstofly.org/kernel/ep93xx-i2c-bus.diff
> > 
> > This seems like a nice opportunity to pimp the driver for
> > upstream inclusion.  I've attached it below.  How does it look?
> > (...)
> > I2C bus driver using ep93xx GPIOs.
> 
> We will have a brand new generic I2C-over-GPIO driver in 2.6.22. As
> the i2c-ep93xx driver relies on GPIO as well, I'd like you to look
> into the generic driver and see how you could use it instead.

Well, for one, the generic i2c gpio driver seems to use the generic
GPIO API, which was broken to begin with, and should never have been
merged.  There have been valid arguments against its inclusion, and
I don't want to promote use of this broken API on ep93xx.

Another issue is that the ep93xx i2c driver supports sharing the i2c
bus with non-i2c agents (this is required for several ep93xx boards),
while the generic i2c gpio driver doesn't seem to support this.

If having upstream i2c support on ep93xx requires adapting the
code to a broken API, then no thanks, I'll maintain ep93xx i2c
support out-of-tree then.


cheers,
Lennert