[i2c] [PATCH 2/5] i2c: Allow preallocation of I2C bus numbers.

David Brownell david-b at pacbell.net
Fri May 18 04:55:38 CEST 2007


I confess I don't quite follow the intent of this patch.

 - i2c_alloc_bus_number() ... why not just have the platform
   maintainer define the numbers?  (Or in the OF case, just
   have the OF glue assign them.)   And it's pointless to
   export this, given it supports calling a non-exported routine.

 - i2c_add_prenumbered_adapter() ... caller should just set
   adapter->number itself and call i2c_add_numbered_adapter();
   no need for a new routine.

Both calls seem useless to me.

- Dave



More information about the i2c mailing list