[i2c] i2c-dev i2c_smbus_read_i2c_block_data update
Jean Delvare
khali at linux-fr.org
Mon May 28 19:32:42 CEST 2007
Hi Mark,
On Sun, 27 May 2007 12:40:26 -0400, Mark M. Hoffman wrote:
> * Jean Delvare <khali at linux-fr.org> [2007-05-23 21:43:25 +0200]:
> > The only drawback is that it doesn't encourage the use of the new code.
> > But I guess we can't have it all. Comments anyone? Mark, your feedback
> > on the py-smbus changes is still needed.
>
> I suggest a couple slight modifications... 1) make the len arg an optional one
> defaulting to 32, so that existing Python code need not be modified at all, and
> 2) add a couple #defines to be sure it builds in all possible environments.
Fine with me. As discussed on IRC yesterday, I applied the non-python
parts myself, and I'll let you commit the py-smbus changes.
> I couldn't test it fully; I don't have a bus w/ I2C_SMBUS_I2C_BLOCK_DATA at the
> moment.
Really? At least I2C block read should be easy, EDID EEPROMs in monitors
support it, all recent monitors support DDC to access these EEPROMs,
and many framebuffer drivers expose the DDC channel as a bit-banged I2C
bus now. nVidia, Intel, Matrox, ATI Radeon and S3 Savage graphics
adapters support that setup, I'd be surprised if you don't have at
least one at hand.
--
Jean Delvare
More information about the i2c
mailing list