[i2c] [PATCH] Is review of AT91 patch pending?

Jean Delvare khali at linux-fr.org
Thu Nov 8 16:04:05 CET 2007


Hi Andrew,

On 08 Nov 2007 09:20:29 +0200, Andrew Victor wrote:
> hi David,
> 
> > > I'd personally prefer if we don't override the existing CONFIG_I2C_AT91
> > > support in the _devices.c file with the GPIO-I2C support, but rather add
> > > a new GPIO-I2C platform device and allow the boards / user to select
> > > which they'd like to use.
> > 
> > Well, I've sent you such a patch ... until you sign off and
> > merge it to the 2.6.24-rc series, the kernel.org tree won't
> > be including I2C support on AT91 chips.  ;)
> 
> As you said when you submitted the patch:
>   Here's an updated patch.  Evidently one of the AT91 patches you
>   sent to Russell (but which hasn't yet merged to kernel.org) has
>   changed I2C init, so this needs some tweaking that I can't sort
>   yet ... Russell suggested you handle the next steps here.
> 
> I was waiting for the AT91 patches to be merged to mainline first.
> 
> Unfortunately there seems to be a new rule (or enforcement of an old
> rule) where patches need to be merged into the subsystem maintainers
> tree before the mainline merge window opens.

Unless these patches fix actual bugs, in which case they can be merged
at any time. The merge window rule applies to patches adding new
features or new drivers, not bug fixes.

As the i2c-at91 driver in its current state is essentially broken, I'd
say that David's patch qualifies as a "bug fix" and thus can be merged
immediately.

> So the AT91 patches are still here:
> http://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cur/arm:devel.diff
> and I think they are unlikely to be merged before 2.6.24 is released.

-- 
Jean Delvare



More information about the i2c mailing list