[i2c] [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h

Julia Lawall julia at diku.dk
Wed Nov 14 07:09:40 CET 2007


>> From: Julia Lawall <julia at diku.dk>
>>
>> Drop #include <linux/moduleparam.h> in files that also include #include
>> <linux/module.h>.  module.h includes moduleparam.h already.
>
> i'm not convinced that's a good idea.  while module.h does currently
> (and unfortunately) include moduleparam.h, there may come a day when
> those header files are refactored to actually make sense, at which
> point all those missing moduleparam.h inclusions will cause all sorts
> of bad things to happen.

They were removed from the drivers/media files in August:
9c12224a607a4b22ab86784e3394b52810b9507c
Perhaps they should be put back there then?

julia




More information about the i2c mailing list