[i2c] [alsa-devel] [PATCH] Add ASoC TLV320 Codec driver.

Mark Brown broonie at opensource.wolfosnmicro.com
Tue Nov 20 13:22:51 CET 2007


On Tue, Nov 20, 2007 at 11:53:25AM +0100, Takashi Iwai wrote:
> Mark Brown wrote:

> > +#define I2C_DRIVERID_TLV320	97	/* TLV 320 audio codec */

> Where is 96? :-)

Sorry, I had another codec queued for addition which I dropped from the
series.  I'll fix this when I resubmit.

> > +#define TLV320_VOICE_BITS \
> > +	(SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE | \
> > +	SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE)

> Double-check if it's really S24_LE or S24_3LE.

Nicola, could you please look into this and also the other issues that
Takashi raised?



More information about the i2c mailing list