[i2c] [alsa-devel] [PATCH] Add ASoC AK4535 codec driver.

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Nov 20 16:05:30 CET 2007


On Tue, Nov 20, 2007 at 11:40:25AM +0100, Takashi Iwai wrote:
> Mark Brown wrote:

> > +config SND_SOC_AK4535
> > +	tristate
> > +	depends on SND_SOC
> > +

> Unless you add another interface support, this driver seems only for
> I2C.  Then let's add dependency on I2C (which will avoid a possible
> unresolved symbol error).

The idiom used by the rest of the ASoC codecs appears to be to omit the
bus dependencies entirely from the codec drivers and rely on the machine
driver pulling in the appropriate bus driver.  For the sake of
consistency I'd rather leave this just now and then separately go
through and address this for all drivers at once - does that seem
sensible to you?

> > --- /dev/null
> > +++ b/sound/soc/codecs/ak4535.c

> ak4535.c has some obvious coding-style issues.
> Try to run scripts/checkpatch.pl and fix the reported parts.

I've fixed up the mechanical issues for next submission.



More information about the i2c mailing list