[i2c] [patch 2.6.23-rc9] remove i2c_algorithm.algo_control(); cleanup
khali at linux-fr.org
Thu Oct 4 10:17:16 CEST 2007
On Wed, 03 Oct 2007 19:21:02 -0700, David Brownell wrote:
> This removes:
> - An effectively unused hook: i2c_algorithm.algo_control.
> - The i2c_control() call, used only by i2c-dev to call that
> unused hook or set two barely supported adapter params.
> (That param setting moves into i2c-dev.c ... still iffy
> due to lack of locking, but no other changes.)
> As shown by diffstat, this is a net code shrink. It also reduces the
> complexity of the I2C adapter and /dev interfaces.
> Signed-off-by: David Brownell <dbrownell at users.sourceforge.net>
> The main potential issue with this is fixing a bug in how i2c-dev
> implements unsupported ioctl requests: it finally reports the error
> to userspace. If needed, the bug could be perpetuated for a while.
> drivers/i2c/i2c-core.c | 22 ----------------------
> drivers/i2c/i2c-dev.c | 14 ++++++++++++--
> include/linux/i2c.h | 7 -------
> 3 files changed, 12 insertions(+), 31 deletions(-)
Looks great. Applied, thanks.
More information about the i2c