[i2c] [PATCH] I2C: add support for the PCF8575 chip

Bart Van Assche bart.vanassche at gmail.com
Tue Oct 23 13:05:37 CEST 2007


On 10/23/07, Trent Piepho <xyzzy at speakeasy.org> wrote:
>
> On Mon, 22 Oct 2007, Andrew Morton wrote:
> > On Fri, 5 Oct 2007 11:32:35 +0200
> > "Bart Van Assche" <bart.vanassche at gmail.com> wrote:
> > > +#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 20)
> > > +static unsigned short normal_i2c_range[] = { I2C_CLIENT_END };
> > > +#endif
> >
> > Please remove all the LINUX_VERSION_CODE tests and target only the
> current
> > mainline tree.
>
> If you want to have a module that can be compiled out of tree and support
> multiple kernel versions, there is a script used in the v4l-dvb out of
> tree
> build system that can make it easier.
>
> http://linuxtv.org/hg/v4l-dvb/raw-file/4ae65d0844cf/v4l/scripts/gentree.pl
>

Thanks Andrew and Trent for the helpful comments -- it was not clear to me
what exactly was wrong with my patch. By this time I have submitted a new
version of the patch.

Regards,

Bart Van Assche.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.lm-sensors.org/pipermail/i2c/attachments/20071023/1cfc3cc7/attachment.html 


More information about the i2c mailing list