[i2c] [PATCH] rtc-pcf8563: Add device ids table

Laurent Pinchart laurentp at cse-semaphore.com
Wed Apr 23 15:53:14 CEST 2008

On Wednesday 23 April 2008 14:47, Jean Delvare wrote:
> On Wed, 23 Apr 2008 14:12:37 +0200, Laurent Pinchart wrote:
> > On Wednesday 23 April 2008 13:16, Jean Delvare wrote:
> > > I still don't know exactly what happened there... I think I saw some
> > > "OpenFirmware i2c" patches go upstream yesterday? But not the ones
> > > listed below, which I thought they depended upon.
> > 
> > The code that went upstream introduces helper functions to create i2c
> > devices from information supplied by the OF device tree. It doesn't
> > strictly depend on the below patches, but the new devices won't be
> > properly bound to a driver without them.
> OK. So... Out of the 7 patches Jochen sent originally, only 1 ([3/7] OF
> helpers for the i2c API) went upstream. Am I correct?
> Jochen, I'm a bit confused by the dependencies that exist - or not -
> between these 7 patches you sent at once. I thought they had to be
> applied in sequence but it seems not? And some of them should
> apparently go through me i2c tree but others (e.g. [7/7]) not?
> I would appreciate if you could summarize quickly which patches depend
> on others in which way. If we can make smaller subsets of patches, that
> will be easier for me to review and push upstream on my limited time.

Here is a summary based on my understanding of the situation. Jochen please 
correct me if I'm wrong.

[PATCH1/7] i2c: Add support for device alias names

This patch allows new-style i2c chip drivers to have alias names using
the official kernel aliasing system and MODULE_DEVICE_TABLE(). It basically 
adds device id table found in various subsystems (PCI, USB, ...) to i2c 
new-style drivers.

The patch extends the new-style i2c device/driver matching code to support 
device id tables. It modifies the drivers accordingly, as the probe function 
now takes an extra argument (pointer to the device id entry that matched), 
but doesn't add device id tables to the drivers.

[PATCH2/7] i2c: Convert all new-style drivers to use module aliasing

This patch adds the device id tables to the new-style i2c drivers. It depends 
on the previous patch.

[PATCH3/7] i2c: OF helpers for the i2c API

This one has already been applied through the ppc subsystem. It adds helper 
functions to instantiate i2c devices from the OF device tree. The patch has 
no compile time dependencies but relies on 1/7 and 2/7 to bind devices to 
drivers at runtime.

[PATCH4/7] i2c: Convert PowerPC MPC i2c to of_platform_driver from 

This patch should go through the ppc subsystem. It adds OF device tree support 
to the i2c-mpc driver. To the best of my knowledge it depends on 3/7 only.

[PATCH5/7] i2c: Kill the old driver matching scheme

This patch removes the old driver_name/type scheme for i2c driver matching. 
Only the new matching scheme introduced by 2/7 remains for new-style drivers.

[PATCH6/7] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

This one introduces a new i2c bus driver. It should go through the ppc 
subsystem. To the best of my knowledge it depends on 3/7 only.

[PATCH7/7] [POWERPC] Add i2c pins to dts and board setup

This last patch configures i2c pins on various powerpc boards and updates the 
associated device trees to include the i2c controller. It should go through 
the ppc subsystem. It has no compile-time dependency on any other patch in 
the serie.

Laurent Pinchart
CSE Semaphore Belgium

Chaussee de Bruxelles, 732A
B-1410 Waterloo

T +32 (2) 387 42 59
F +32 (2) 387 42 75
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/i2c/attachments/20080423/ed563b62/attachment.bin 

More information about the i2c mailing list