[i2c] [PATCH] i2c-piix4: Minor cleanups

Jean Delvare khali at linux-fr.org
Sat Apr 26 11:05:31 CEST 2008


* Remove a needless include.
* Remove a legacy comment in piix4_access.
* Minor optimization in piix4_access.

Signed-off-by: Jean Delvare <khali at linux-fr.org>
---
 drivers/i2c/busses/i2c-piix4.c |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

--- linux-2.6.26-rc0.orig/drivers/i2c/busses/i2c-piix4.c	2008-04-26 10:44:05.000000000 +0200
+++ linux-2.6.26-rc0/drivers/i2c/busses/i2c-piix4.c	2008-04-26 10:49:16.000000000 +0200
@@ -38,7 +38,6 @@
 #include <linux/ioport.h>
 #include <linux/i2c.h>
 #include <linux/init.h>
-#include <linux/apm_bios.h>
 #include <linux/dmi.h>
 #include <asm/io.h>
 
@@ -343,12 +342,7 @@ static s32 piix4_access(struct i2c_adapt
 
 
 	switch (size) {
-	case PIIX4_BYTE:	/* Where is the result put? I assume here it is in
-				   SMBHSTDAT0 but it might just as well be in the
-				   SMBHSTCMD. No clue in the docs */
-
-		data->byte = inb_p(SMBHSTDAT0);
-		break;
+	case PIIX4_BYTE:
 	case PIIX4_BYTE_DATA:
 		data->byte = inb_p(SMBHSTDAT0);
 		break;


-- 
Jean Delvare



More information about the i2c mailing list