[i2c] [RFC] PXA3xx: Add support for power i2c bus

Mike Rapoport mike at compulab.co.il
Thu Aug 14 12:28:54 CEST 2008



Eric Miao wrote:
> On Thu, Aug 14, 2008 at 4:55 PM, Mike Rapoport <mike at compulab.co.il> wrote:
>> This patch adds support for power i2c bus on PXA3xx processor.
>>
>> Signed-off-by: Mike Rapoport <mike at compulab.co.il>
>>
> 
> I'd like the i2c driver to be converted to ioremap() and {read,write}l()
> first before this can happen.

It is already using {read,write}l() unless I'm realy missing something...


> pxa27x_set_i2c_power_info()
> 
> and
> 
> pxa3xx_set_i2c_power_info()
> 
> are OK to co-exist, no need for a unified version. IOW, I'd prefer
> the previous invocations of pxa_set_i2c_power_info() to be
> renamed "pxa27x_set_i2c_power_info()"

Ok.

> The caller is supposed to know which to call.
> 

-- 
Sincerely yours,
Mike.




More information about the i2c mailing list