[i2c] [PATCH] i2c: fix i2c-sh_mobile timing issues

Jean Delvare khali at linux-fr.org
Wed Aug 27 17:46:28 CEST 2008


On Wed, 27 Aug 2008 23:40:48 +0900, Paul Mundt wrote:
> On Wed, Aug 27, 2008 at 06:33:56PM +0900, Magnus Damm wrote:
> > From: Magnus Damm <damm at igel.co.jp>
> > 
> > This patch teaches the i2c-sh_mobile driver to make use of wait irqs.
> > Without this patch only dte irqs are used which may lead to overruns
> > and cases of missing stop and extra bytes being read on the i2c bus.
> > 
> > Use of wait irqs forces the hardware to pause and wait until the cpu
> > is ready. Polling is also reworked in this patch to fix ms delay issues.
> > 
> > Verified with bus analyzer and tested on MigoR and AP325RXA boards.
> > 
> > Signed-off-by: Magnus Damm <damm at igel.co.jp>
> > ---
> > 
> >  Paul, can you merge this for 2.6.27?
> > 
> >  drivers/i2c/busses/i2c-sh_mobile.c |  271 +++++++++++++++++++++++++++---------
> >  1 file changed, 208 insertions(+), 63 deletions(-)
> > 
> I'll add it to my queue if Jean and Ben don't have any issues with the
> patch. If the polling works as is, I would suggest that it is not 2.6.27
> material, but if it's fixing operational bugs then it doesn't make sense
> to leave 2.6.27 in a known broken state.

No objection from me, as this is outside of my jurisdiction.

-- 
Jean Delvare



More information about the i2c mailing list