[i2c] [PATCH 2/2] I2C: ISP1301_OMAP: New-style i2c driver updates, part 2

David Brownell david-b at pacbell.net
Sat Feb 23 20:53:03 CET 2008


On Saturday 23 February 2008, Jean Delvare wrote:
> On Sat, 23 Feb 2008 10:10:39 -0800, David Brownell wrote:
> > On Saturday 23 February 2008, Felipe Balbi wrote:
> > > Thanks Dave, the patch is attached. patch 1 is acked by Jean, right Jean?
> 
> Yes, except that my copy has "isp->irq_type = 0;" removed.

From a bzeroed structure?  Then I won't worry about that difference...


> > But not yet in the I2C merge queue??
> 
> I was waiting for the second part. The first part doesn't make much
> sense alone. I could add the first part to my i2c tree, but I can't
> merge it upstream without the second part.

That makes no sense to me.  If the first part is OK, it's OK to
merge without the second part.

Even if you don't _plan_ to merge it soon, it'd be less confusing
to have that in your queue ... say, towards the end, below a line
that indicates a scheduled merge point.  (FWIW that's not unlike
Andrew does with MM.)

- Dave



More information about the i2c mailing list