[i2c] [PATCH 2/2] I2C: ISP1301_OMAP: New-style i2c driver updates, part 2

[Felipe Balbi]

On Tue, Feb 26, 2008 at 7:38 AM, David Brownell <david-b at pacbell.net> wrote:
> On Monday 25 February 2008, Felipe Balbi wrote:
>  > Jean, I'm thinking about introducing include/asm/arch/isp1301.h
>
>  Or maybe isp1301_omap.h to match the driver name.
>
>
>
>  > so I
>  > can introduce struct isp1301_platform_data to pass irq_flags to the
>  > driver.
>
>  Passing irq_flags???  That sounds like nonsense.  Please explain ...

request_irq was using different irq flags depending on the board, so
instead of keeping if (machine_is_*) in the driver just because of irq
flags we could bring it from a platform_data.

>
>
>  By the way, I see why there's no board-h2.c update.  One of
>  the patches in December stripped out most of the tps65010
>  i2c_board info from mainline, replacing some of it with
>  isp1301 stuff ... that can't possibly work in mainline.
>
>  So there are going to be some H2 and H3 regression-fix
>  patches upcoming...

that's true...

-- 
Best Regards,

Felipe Balbi
felipebalbi at users.sourceforge.net