[i2c] [PATCH] Add support for the S-35390A RTC chip.

[Byron Bradley]

On Jan 6, 2008 6:01 PM, Jean Delvare <khali at linux-fr.org> wrote:
> Hi Byron,
>
> On Sat,  5 Jan 2008 22:58:14 +0000, Byron Bradley wrote:
> > This adds basic get/set time support for the Seiko Instruments
> > S-35390A. This chip communicates using I2C and is used on the
> > QNAP TS-109/TS-209 NAS devices. It takes up eight addresses on
> > the I2C bus and depends on the following patches:
> >
> >       i2c-remove-redundant-i2c_client-list.patch
> >       i2c-add-i2c_new_dummy-utility.patch
> >
> > Signed-off-by: Byron Bradley <byron.bbradley at gmail.com>
> > Tested-by: Tim Ellis <tim at ngndg.com>
> > Cc: Jean Delvare <khali at linux-fr.org>
> > Cc: David Brownell <david-b at pacbell.net>
> > ---
> >  drivers/rtc/Kconfig       |    9 ++
> >  drivers/rtc/Makefile      |    1 +
> >  drivers/rtc/rtc-s35390a.c |  316 +++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 326 insertions(+), 0 deletions(-)
> >  create mode 100644 drivers/rtc/rtc-s35390a.c
>
> Acked-by: Jean Delvare <khali at linux-fr.org>
>
> With just one comment:
>
> > +     /* This chip uses multiple addresses, use dummy devices for them */
> > +     for (i = 1; i < 8; ++i) {
> > +             s35390a->client[i] = i2c_new_dummy(client->adapter,
> > +                                     client->addr + i, "rtc-s35390a");
> > +             if (!s35390a->client[i]) {
> > +                     dev_err(&client->dev, "Address %d unavailable\n",
> > +                                             client->addr + i);
> > +                     err = -ENOCSI;
> > +                     goto exit_dummy;
> > +             }
> > +     }
>
> -ENOCSI? Don't you rather mean -EBUSY?
>
> Also, the address would be better printed as an hexadecimal value -
> decimal I2C addresses isn't something people are used to.
>
> You should get your driver reviewed by Alessandro Zummo now, and then
> it can be merged upstream... After the i2c cleanups it depends on are
> upstream themselves, that is (working on it.)

Thanks Jean, I've sent it to Alessandro Zummo and the rtc-linux list.

David, the ENOCSI comment probably applies to your at24 eeprom driver
too. I was wondering why that error code was chosen since other than
"No CSI structure available" I couldn't find anything about it.

Cheers,

-- 
Byron Bradley