[i2c] [PATCH] Add support for the S-35390A RTC chip.

Jean Delvare khali at linux-fr.org
Tue Jan 8 14:01:24 CET 2008


On Tue, 8 Jan 2008 04:39:27 -0800, David Brownell wrote:
> On Tuesday 08 January 2008, Jean Delvare wrote:
> > 
> > > In fact it's common practice to adopt subsystem-specific conventions
> > > about what a given errno value indicates.  Otherwise, almost every
> > > fault observed would map to a small handful ... making them useless
> > > for fault recovery logic, and at best problematic in terms of any
> > > diagnostic utility.
> > 
> > A common practice to use random error codes
> 
> Hey, *I* didn't say "random error codes".
> 
> 
> > just to make sure they are 
> > unique? I don't think so, no. Resource not available is EBUSY, not
> > ENOCSI, period. Please fix your driver.
> 
> Actually, "address in use" is EADDRINUSE.  I made that change.
> 
> (Another reason to use oddball errno values is as a placeholder
> until a more appropriate one is found.)

OK, EADDRINUSE is equally fine with me.

-- 
Jean Delvare



More information about the i2c mailing list