[i2c] [RFC PATCH 3/8] Add PCA9536 4 bit I2C GPIO extender support to the pca9539 GPIO driver

David Brownell david-b at pacbell.net
Thu Jan 31 12:49:41 CET 2008


On Thursday 31 January 2008, Guennadi Liakhovetski wrote:
> 
> > > So, actually, using my descriptor array is nearer to what it eventually 
> > > should become, I think. Under 2.6.26 you'd also, probably, just have a 
> > > "struct i2c_device_id *" member in your pca953x_chip.
> > 
> > Well, I was also pointing out that all you need is the number of GPIOs;
> > no need to save any ID struct at all.  These chips are VERY similar.
> 
> Ok, agreed, let's remove it then. For now I just use an array of structs 
> similar to i2c_device_id only to avoid a long sequence of strcmp calls in 
> probe() and compare the name in a loop. Is this alright?

Sure; it's your call on most such details, I just wanted clean patches.




More information about the i2c mailing list