[i2c] [PATCH 3/3] Add support for PCA953[4-8] I2C GPIO extenders to the pca953x driver

David Brownell david-b at pacbell.net
Thu Jan 31 22:20:57 CET 2008


On Thursday 31 January 2008, Guennadi Liakhovetski wrote:
> +/* This is only temporary - should go with 2.6.26. Only introduced now
> + * to avoid a sequence of strcmp() calls and just compare in a loop */
> +struct pca953x_desc {
> +       unsigned int    gpios;
> +       char            *name;
> +};

This is a bit sub-optimal; if it were the same as i2c_device_id then
less code would need to change later.  So I'll probably tweak that bit
before sending it on.

Otherwise, fine ... thanks!

- Dave



More information about the i2c mailing list