[i2c] [PATCH 1/1] I2C pxa fast mode (400khz) support

David Brownell david-b at pacbell.net
Sat Jul 12 23:35:06 CEST 2008


> >> I think use_pio and fast_mode could both be bits.
> > 
> > Or alternatively, "bool" ... which is usually a byte, and
> > on ARM will let GCC eliminate a comparision instruction.
> > Just load byte and branch on zero/nonzero, vs needing one
> > more instruction.
> 
> Unfortunately, on ARM the LDR/LDRB instructions can not
> update the condition codes.

Right, sorry -- I was looking at MOV not LDRB.

I don't use assembler often enough to remember
that little asymmetry:  data movement involving
memory uses different notations and instructions.

If only the instruction set were as regular as
a PDP-11 ... ;)




More information about the i2c mailing list