[i2c] [PATCHv2 3/3] Add platform driver on top of the new

[David Brownell]

> +#ifdef CONFIG_GENERIC_GPIO
> +#include <asm/gpio.h>
> +#endif

You should #include <linux/gpio.h> now and avoid a lot
of this #ifdeffery ... which is something I think you'd
be told by running checkpatch.pl on 2.6.25-rc5, as well
as most RC4 kernels.


> +	/* Use NO_GPIO when this macro is in mainline */

I hope you mean gpio_is_valid() instead... that's in MM,
but not yet mainline (except when <linux/gpio.h> is all
stubs).

- Dave