[i2c] [PATCH] ASoC/TLV320AIC3X: Stop I2C driver ID abuse

Jean Delvare khali at linux-fr.org
Thu Mar 20 17:35:50 CET 2008


Please stop using random I2C driver IDs.

Also removed a pointless initialization to 0 of a static struct member.

Signed-off-by: Jean Delvare <khali at linux-fr.org>
Cc: Jarkko Nikula <jarkko.nikula at nokia.com>
---
I will push this to Linus through my i2c tree by the end of the week.

 sound/soc/codecs/tlv320aic3x.c |    2 --
 1 file changed, 2 deletions(-)

--- linux-2.6.25-rc6.orig/sound/soc/codecs/tlv320aic3x.c	2008-03-20 17:03:40.000000000 +0100
+++ linux-2.6.25-rc6/sound/soc/codecs/tlv320aic3x.c	2008-03-20 17:03:42.000000000 +0100
@@ -1187,10 +1187,8 @@ static struct i2c_driver aic3x_i2c_drive
 		.name = "aic3x I2C Codec",
 		.owner = THIS_MODULE,
 	},
-	.id = I2C_DRIVERID_I2CDEV,
 	.attach_adapter = aic3x_i2c_attach,
 	.detach_client = aic3x_i2c_detach,
-	.command = NULL,
 };
 
 static struct i2c_client client_template = {


-- 
Jean Delvare



More information about the i2c mailing list