[i2c] [PATCH 184.108.40.206] rtc-ds1307 : SMBus compatibility
david-b at pacbell.net
Sun Oct 12 06:50:20 CEST 2008
On Friday 10 October 2008, Jean Delvare wrote:
> Unfortunately your e-mail client replaced all tabs with spaces in the
> patch, so I can't apply it, which makes reviewing it much harder.
> Here's a first pass anyway, but please fix that and resend the patch in
> such a format that I (and other developers) can apply it.
... and test it.
At a quick glance, this looks like a sane conversion ... unlike the last
one proposed, which I had to NAK since it broke driver functionality by
trying to replace block transfers with non-equivalent byte-at-a-time ones.
(Clock updates between bytes, boom!)
> Note that while this patch deals with I2C, it affects an RTC driver so
> you should send it to the RTC subsystem maintainer (Alessandro, Cc'd)
> and mailing list. You might also want to get the last developers who
> touched the rtc-ds1307 driver to test your patch. I've Cc'd them as
Right. As a rule, use GIT history to see who's maintaining code
when there's no MAINTAINERS entry.
More information about the i2c