[i2c] [PATCH 2/6]: i2c-pcf: Add adapter hooks around xfer begin and end.

David Miller davem at davemloft.net
Wed Oct 15 23:32:12 CEST 2008


From: Jean Delvare <khali at linux-fr.org>
Date: Wed, 15 Oct 2008 14:19:14 +0200

> Of course we can start with a local implementation in i2c-algo-pcf and
> we move it to i2c-core later if needed.

Please let's be practical and handle things this way.

> That's not exactly elegant. I'd rather make .xfer_begin and .xfer_end
> optional and check for NULL before calling them from pcf_xfer(). That's
> less intrusive also, you don't even need to touch the individual bus
> drivers using the i2c-algo-pcf module if they don't need these hooks.

I think it's more elegant to remove as many conditionals from
generic code as possible.

Where were you 2 months ago when I submitted these patches?

I've forgotten most of the state of these changes since then
and now I have to reload all of my context in.

And because you're doing this feedback _NOW_ it's a very real
chance that we'll miss 2.6.28 with these changes.  And I can't
work on any further sparc I2C stuff I had in mind until this
stuff is settled :-(



More information about the i2c mailing list