[i2c] [PATCH 5/7] of/gpio: implement of_dev_gpiochip_{add, remove} calls

David Brownell david-b at pacbell.net
Fri Oct 17 22:25:01 CEST 2008


On Thursday 16 October 2008, Anton Vorontsov wrote:
> +       if (of_gc->chip)
> +               return of_gc->chip;
> +       return &of_gc->gc;

presumably there's a reason not to

	of_gc->chip = &of_gc->gc;

when this gets set up, so this can always be a simple

	return of_gc->chip;

(and inlined)?  Needlessly complex...





More information about the i2c mailing list