mds at paradyne.com
Sun Dec 15 05:22:17 CET 2002
I'm reaching the limits of my ability to stare at code and imagine
timing diagrams in my head, but here goes.
BTW, I want to make sure you've read the suggestions Dori Eldar made this summer,
which I summarized in i2c/TODO. They're the ones marked "D.E.".
If you have questions on those I may be able to help.
Note that I don't necessarily agree with each suggestion,
so we can talk about it. Many of the suggestions would
require i2c-core enhancements as well.
Kyösti Mälkki wrote:
> On Tue, 10 Dec 2002, Mark Studebaker wrote:
>>One question - is clock low time == udelay at end of a
>>read, including end of i2c_inb and i2c_stop? it looks to me like
>>it's only Tmin + Tmin?
> Did you mean "end of i2c_inb and i2c_outb"? At end of i2c_stop clock
> remains high, perhaps need to insert missing "Stop to Start" delay
I wasn't talking about stop-to-start delay but that could be...
it appears that a stop-to-start delay of udelay is acceptable.
> For repetive inb/outb clock low after ACK is T_hold+T_setup == T_scllo.
> Between inb/outb ACK and stop, it is T_hold+T_min == T_min+T_min,
> should really be T_hold+T_setup there.
Right. This is what I was talking about, between inb/outb ACK and stop.
So we agree that needs to be fixed.
>>One other general comment - sdalo() and sdahi() could be deleted
>>and inlined into test_bus(), which is the only place they're used?
> I thought of adding 'paranoid' mode, that reads back bus state after
> any set. This is likely to recombine bus set, get and delay in one
> inlined call.
>>>I have been reading the "Fast Mode" specs to test my setup, at some
>>>points the 1 us I use violates this.
>>Disagree. If you think about it, the max hold spec really only applies
>>when you are an i2c slave.
> Actually, I meant 1 us violates "bus free time between Stop and
> Start", "Low period of SCL" and "SCL clock frequency".
> With 1us resolution best we can do within fast mode specs is
> udelay=2 and get 250kHz. I think stock kernel tree doesn't export
> anything to improve the resolution, so I will settle for udelay.
Agreed. Fast mode max is a udelay of 1.25. If people want to
violate that and set a udelay of 1, they can at their peril.
We should add documentation that a udelay of 2 (250 kHz) is a practical
lower limit and we do not recommend a udelay of 1.
When nanosleep or whatever gets exported, we can do better.
>>>The i2c_adapter->retry now applies to complete message. Previously
>>>it would fail on any [NA] after the address [A].
>>>I am not 100% sure how auto-incrementing EEPs will tolerate it,
>>>if we fail in the middle of a page and then resend from the beginning.
>>We may want to think about this more. Or maybe do something different
>>on reads than on writes. We don't want to corrupt eeproms.
> Yep. Thinking more into it, correct retry sequence is device specific if
> failure happens after address byte. Both i2c<->async and i2c<->parallel
> converters should continue with with the first failed byte.
> Should we keep adapter->retry for address retry? Getting [NA] for
> address may reflect eeprom busy writing, disconnected device or
> bus problems. Do SMBus hosts ignore this?
Reading ticket 517 more carefully, the i2c-core layer DOES return
error codes pretty faithfully. I thing the bus drivers do too.
So I misspoke. It's the CHIP drivers that generally ignore the
error returns and the -1 return gets cast to an FF value.
Should we keep adapter->retry? Seems like more trouble than it is worth.
Maybe you could hold it back as part 2 of the patch?
>>>A message may be sent correctly after ignored [NA], retry or timeout.
>>>The caller could check this in i2c_msg->err, if necessary.
>>OK. But the whole mechanism of saving and checking the error, etc. is
>>somewhat elaborate, not sure if useful or not. If you look at the
>>smbus-layer calls (which in turn use the "emulation layer" if the
>>adapter is i2c-only), errors aren't returned at all.
Not true, as explained above.
> With algo-bit this is messy, for SMBus style adapter, you can get return
> code from status register directly? For simplicity, the errorcode
> set in adapter driver could pass unchanged to the caller. If adapter
> drivers already return <0 for failure, nothing is changed from the
> caller's point of view. Unless they test for -1 explicitly, which they
> should not.
The i2c_smbus_xxx_xxx calls return an s32, -1 on failure.
In a chip driver, for example, it should probably check for -1
returns and throw out that reading, and show the user the last good reading.
Otherwise, cast s32 to u8 as usual.
> Some means (besides log) to report a stuck or disconnected bus may be
> necessary to support removable SMBus devices like batteries, AC adapters
More information about the lm-sensors