[PATCH 2.6.0-test3]bugfix for initialization bug in adm1021 driver

Rusty Lynch rusty at linux.co.intel.com
Wed Aug 13 01:38:13 CEST 2003


While initializing the adm1021 device, the driver is performing a conversion
from fixed point to Celcius on values that were declaired as Celcius.  On
my Dell Precision 220 this results in a shutdown after a couple of minutes
running.

This is a very simple patch against the 2.6.0-test3 tree that just removes the
conversion.

    --rustyl


diff -urN linux-2.6.0-test3/drivers/i2c/chips/adm1021.c linux-2.6.0-test3-patched/drivers/i2c/chips/adm1021.c
--- linux-2.6.0-test3/drivers/i2c/chips/adm1021.c	2003-08-08 21:31:16.000000000 -0700
+++ linux-2.6.0-test3-patched/drivers/i2c/chips/adm1021.c	2003-08-12 16:54:25.000000000 -0700
@@ -356,13 +356,13 @@
 {
 	/* Initialize the adm1021 chip */
 	adm1021_write_value(client, ADM1021_REG_TOS_W,
-			    TEMP_TO_REG(adm1021_INIT_TOS));
+			    adm1021_INIT_TOS);
 	adm1021_write_value(client, ADM1021_REG_THYST_W,
-			    TEMP_TO_REG(adm1021_INIT_THYST));
+			    adm1021_INIT_THYST);
 	adm1021_write_value(client, ADM1021_REG_REMOTE_TOS_W,
-			    TEMP_TO_REG(adm1021_INIT_REMOTE_TOS));
+			    adm1021_INIT_REMOTE_TOS);
 	adm1021_write_value(client, ADM1021_REG_REMOTE_THYST_W,
-			    TEMP_TO_REG(adm1021_INIT_REMOTE_THYST));
+			    adm1021_INIT_REMOTE_THYST);
 	/* Enable ADC and disable suspend mode */
 	adm1021_write_value(client, ADM1021_REG_CONFIG_W, 0);
 	/* Set Conversion rate to 1/sec (this can be tinkered with) */





More information about the lm-sensors mailing list