SAA1064 sensors chip driver
Jean Delvare
khali at linux-fr.org
Tue Jul 15 20:40:37 CEST 2003
> > > Another small thing (@all *g*):
> > > Most of your modules lack the #ifdef MODULE...#endif construct
> > > usually embracing init_module and cleanup_module. That prevents
> > > most of these to run smoothly compiled into the kernel. Is this a
> > > bug or a feature?
> >
> > Bug, definitely. I noticed this too, because I didn't do so in my
> > own driver... I'll check every driver tomorrow. Anyway, drivers that
> > get mkpatched must be OK, or I guess someone would have noticed, by
> > the time...
>
> No, this isn't a bug. The #ifdef MODULE is not needed anymore. Just
> use:
> module_init(foo_init());
> module_exit(foo_exit());
>
> and everything will work just fine for when the code is build as a
> module or within the kernel.
OK, thanks for the clarification :)
--
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
More information about the lm-sensors
mailing list