[PATCH 2.6] it87 reset option

Jean Delvare khali at linux-fr.org
Sun Feb 29 09:18:41 CET 2004


Replying to myself.

> > +		tmp = (tmp & 0xc0) | 0x2a;
> > +		it87_write_value(client, IT87_REG_TEMP_ENABLE, tmp);
> > +	}
> > +	data->sensor = tmp;
> 
> I don't think this is needed. That value will be updated in
> it87_update_client, and this function will be called at least once
> before you access data->sensor again.

I'm wrong here. The line is indeed required, in case someone tries to
set the sensor types from user-space before reading anything from the
chip (and this is very likely to happen since we encourage people to run
"sensors -s" right after loading the modules).

So sorry (again...) for the noise. Still my two other remarks make
sense...

Thanks.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/



More information about the lm-sensors mailing list