[PATCH 2.6] Prevent i2c-dev oops with debug

Jean Delvare khali at linux-fr.org
Wed Mar 10 09:27:02 CET 2004


Quoting Greg KH <greg at kroah.com>:

> > I agree that we need to calm down a bit ;) but there are a
> > several oops preventing patches in my list (i2c-core, i2c-i801,
> > i2c-sis5595, i2c-ali1535 and now i2c-dev). Shouldn't these simple
> > but important fixes be sent to Linus?
> 
> They only happen when people enable debugging, right?  That's a
> pretty simple fix :)

This is correct for i2c-core and i2c-dev (that said, you wouldn't figure
how many people actually enable these options...), but the issue with
the three bus drivers is different. The oops occur when unloading the
modules if the corresponding hardware has not been detected. I agree
that this is a not-so-common case, but it still can occur, and isn't
related to debugging.

(BTW, why do these modules accept to load if no hardware matches? Just
in case the hardware is hot-plugged later?)

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/



More information about the lm-sensors mailing list